RFR: 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type() [v2]

Ao Qi aoqi at openjdk.java.net
Tue Oct 19 07:41:50 UTC 2021


On Tue, 19 Oct 2021 07:18:03 GMT, SUN Guoyun <duke at openjdk.java.net> wrote:

>> src/hotspot/share/adlc/output_h.cpp line 1947:
>> 
>>> 1945:       // Special special hack to see if the Cmp? has been incorporated in the conditional move
>>> 1946:       MatchNode *rl = instr->_matrule->_rChild->_lChild;
>>> 1947:       if( rl && !strcmp(rl->_opType, "Binary") && rl->_rChild && strncmp(rl->_rChild->_opType, "Cmp", 3) == 0) {
>> 
>> Code style. Use `if (rl &&`.
>
> Done

It's still `if( rl`, please update to `if (rl`. Copyright year also needs an update.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5369


More information about the hotspot-compiler-dev mailing list