RFR: 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend [v11]

[Ningsheng Jian]

On Tue, 19 Oct 2021 07:29:15 GMT, Wang Huang <whuang at openjdk.org> wrote:

>> * In this issue, we plan to complete all missing implementation for aarch64 neon backend. For example, cast from Byte to Long, cast from Long to Byte, and so on.
>> * It may be a solver of JDK-8269866, or part of it.
>
> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   merge master

Looks good to me. Just some style nits.

src/hotspot/cpu/aarch64/aarch64_neon.ad line 330:

> 328:   match(Set dst (VectorCastI2X src));
> 329:   format %{ "xtn  $dst, T4H,  $src, T4S\n\t"
> 330:             "xtn  $dst, T8B, $dst, T8H\t# convert 4I to 4B vector"

nit: remove one space between "T4H,  $src".

src/hotspot/cpu/aarch64/aarch64_neon.ad line 353:

> 351: %}
> 352: instruct vcvt2Lto2F(vecD dst, vecX src)
> 353: %{

nit: one blank line between each generated rule.

src/hotspot/cpu/aarch64/aarch64_neon.ad line 427:

> 425: %}
> 426: instruct vcvt4Bto4F(vecX dst, vecD src)
> 427: %{

Add blank line between L425 and L426

src/hotspot/cpu/aarch64/aarch64_neon.ad line 517:

> 515: %}
> 516: instruct vcvt4Fto4B(vecD dst, vecX src)
> 517: %{

And here

-------------

Marked as reviewed by njian (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4839