RFR: 8275104: IR framework does not handle client VM builds correctly

Christian Hagedorn chagedorn at openjdk.java.net
Thu Oct 21 07:04:29 UTC 2021


On Wed, 20 Oct 2021 11:19:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> While the IR framework is primarily used for C2 IR verification, it should also work with client VM builds. There are currently some problems which are fixed with this patch:
> 
> - The IR framework currently only bails out of IR matching if C2 is excluded by command line flags. However, when running an IR JTreg test with a client VM build, IR matching fails when not specifically adding `@requires vm.compiler2.enabled` to exclude the test.
> - `@Test` and `@ForceCompile` do not work correctly and throw an exception due to an incompatible compilation level selection without C2.
> - Some internal framework tests fail (the fix also improves `TestDIgnoreCompilerControls` in general).
> 
> Testing:
> 
> - Standard tier testing
> - Testing internal framework tests with standard build (tiered), client VM (without C2) and server VM build (without C1)
> 
> Thanks,
> Christian

Thanks Vladimir for your review!

Given that 8273712 is going to deprecate `MinInliningThreshold`, I've changed the flag in `IRExample` to another int based flag: `TypeProfileLevel`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6037


More information about the hotspot-compiler-dev mailing list