RFR: 8259609: C2: optimize long range checks in long counted loops [v3]
Tobias Hartmann
thartmann at openjdk.java.net
Fri Oct 22 07:07:09 UTC 2021
On Mon, 25 Jan 2021 09:55:50 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Roland Westrelin has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - min_jint overflow fix
>> - Revert "assert(static_cast<T1>(result) == thing) fix"
>>
>> This reverts commit e234477df097475d503ea6f94ab6a258132d165e.
>
> src/hotspot/share/opto/loopTransform.cpp line 2584:
>
>> 2582: if (p_offset != NULL) {
>> 2583: if (*p_scale == min_signed_integer(bt)) {
>> 2584: return false;
>
> I find it suspicious that this edge case needs to be handled here. Could you explain why and add a corresponding comment?
Looks like you forgot to address this comment?
-------------
PR: https://git.openjdk.java.net/jdk/pull/2045
More information about the hotspot-compiler-dev
mailing list