RFR: 8275104: IR framework does not handle client VM builds correctly [v2]

Tobias Hartmann thartmann at openjdk.java.net
Fri Oct 22 08:52:09 UTC 2021


On Thu, 21 Oct 2021 07:04:29 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> While the IR framework is primarily used for C2 IR verification, it should also work with client VM builds. There are currently some problems which are fixed with this patch:
>> 
>> - The IR framework currently only bails out of IR matching if C2 is excluded by command line flags. However, when running an IR JTreg test with a client VM build, IR matching fails when not specifically adding `@requires vm.compiler2.enabled` to exclude the test.
>> - `@Test` and `@ForceCompile` do not work correctly and throw an exception due to an incompatible compilation level selection without C2.
>> - Some internal framework tests fail (the fix also improves `TestDIgnoreCompilerControls` in general).
>> 
>> Testing:
>> 
>> - Standard tier testing
>> - Testing internal framework tests with standard build (tiered), client VM (without C2) and server VM build (without C1)
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change MinInliningThreshold to TypeProfileLevel in IRExample

Looks good to me.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6037


More information about the hotspot-compiler-dev mailing list