RFR: 8273585: String.charAt performance degrades due to JDK-8268698 [v2]

Yi Yang yyang at openjdk.java.net
Tue Oct 26 02:14:47 UTC 2021


On Mon, 25 Oct 2021 12:27:42 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use uncast
>
> src/hotspot/share/opto/loopnode.cpp line 3184:
> 
>> 3182:         !incr2->in(2)->is_Con())
>> 3183:       continue;
>> 3184:     if (incr2->in(1) != phi2) {
> 
> You could use incr2->in(1)->uncast() != phi2. You don't need to add an extra if then.

Since the semantic of uncast is enough clear, I also remove the comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6096


More information about the hotspot-compiler-dev mailing list