RFR: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed [v2]

Vladimir Kozlov kvn at openjdk.java.net
Thu Oct 28 21:30:13 UTC 2021


On Thu, 28 Oct 2021 20:25:47 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> We need to handle the case when the allocation input to `VectorBoxNode` is a phi but the vector input is not, which can definitely be the case if the vector input has been value-numbered. It seems to be safe to do by construction because `VectorBoxNode` and `VectorBoxAllocation` come in a specific order as a result of expanding an intrinsic call. After that, if any of the inputs to VectorBoxNode are value-numbered they can only move up and are guaranteed to dominate.
>
> Igor Veresov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix spelling.
>  - Add comments.

Good

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6162


More information about the hotspot-compiler-dev mailing list