RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations [v4]

[John Tortugo]

On Wed, 1 Sep 2021 00:23:11 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> Hi, can I please get some reviews for this Pull Request? Here is a summary of the changes:
>> 
>> - Add tests, using the new IR-based test framework, for several of the Ideal transformations on Add, Sub, Mul, Div, Loop nodes and some simple Scalar Replacement transformations.
>> - Add more default IR regex's to IR-based test framework.
>> - Changes to Sub, Div and Add Ideal nodes to that transformations on Int and Long types are the whenever possible same.
>> - Changes to Sub*Node, Div*Node and Add*Node Ideal methods to fix some bugs and include new transformations.
>> - New JTREG "ir_transformations" test group under test/hotspot/jtreg.
>
> John Tortugo has updated the pull request incrementally with 146 additional commits since the last revision:
> 
>  - Fix merge mistake.
>  - Merge branch 'jdk-8267265' of https://github.com/JohnTortugo/jdk into jdk-8267265
>  - Addressing PR feedback: move tests to other directory, add custom tests, add tests for other optimizations, rename some tests.
>  - 8273197: ProblemList 2 jtools tests due to JDK-8273187
>    8273198: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>    
>    Reviewed-by: naoto
>  - 8262186: Call X509KeyManager.chooseClientAlias once for all key types
>    
>    Reviewed-by: xuelei
>  - 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
>    
>    Reviewed-by: ayang
>  - 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
>    
>    Reviewed-by: jiefu, serb
>  - 8273092: Sort classlist in JDK image
>    
>    Reviewed-by: redestad, ihse, dfuchs
>  - 8273144: Remove unused top level "Sample Collection Set Candidates" logging
>    
>    Reviewed-by: iwalulya, ayang
>  - 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
>    
>    Co-authored-by: Jan Lahoda <jlahoda at openjdk.org>
>    Co-authored-by: Vicente Romero <vromero at openjdk.org>
>    Reviewed-by: jlahoda
>  - ... and 136 more: https://git.openjdk.java.net/jdk/compare/ac430bf7...463102e2

Hi folks,

I'd appreciate if you could take a look again. I addressed the comments so far and here is a summary of the latest changes:

- Moved all tests to directory `/compiler/c2/irTests` under hotspot JTREG group.
- Added a few `custom run tests` for testing some corner cases.
- Renamed some tests files and some test methods.
- Added new tests for testing the changes introduced by [JDK-8270823](https://bugs.openjdk.java.net/browse/JDK-8270823)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135