RFR: 8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert

Vladimir Ivanov vlivanov at openjdk.java.net
Wed Sep 1 13:06:11 UTC 2021


The fix for JDK-8271276 uncovered another problem with incremental inlining through 
virtual call sites: receiver null check breaks exception state combining in `GraphKit::replace_call()`
because the associtated exception path has the JVM state representing the point
right before the call (arguments are on stack).

I propose a conservative fix which bails out the inlining attempt when receiver is not provably non-null.

IMO the proper fix is to always add explicit receiver null check and teach
`Block::implicit_null_check()` about CallDynamicJava nodes. But that's for a
separate change.

Testing: failing tests, hs-tier1 - hs-tier4

-------------

Commit messages:
 - Require non-null receiver

Changes: https://git.openjdk.java.net/jdk/pull/5330/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5330&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8273165
  Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5330.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5330/head:pull/5330

PR: https://git.openjdk.java.net/jdk/pull/5330


More information about the hotspot-compiler-dev mailing list