RFR: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic

Vladimir Ivanov vlivanov at openjdk.java.net
Wed Sep 1 14:17:18 UTC 2021


On Wed, 25 Aug 2021 22:17:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

> `Unsafe::copyMemory0` intrinsic unconditionally inserts barriers arounds the call to `unsafe_arraycopy` stub.
> It is a conservative approach and barriers can be avoided in most common cases (similar to what is done for scalar unsafe accesses).
> 
> `Unsafe::copyMemory()` performs argument validation which limits inputs either
> to off-heap location (null + absolute address) or primitive on-heap array.
> 
> The only cases when barriers are still needed are:
>  * mixed accesses (`Object+offset`);
>  * mismatched access due to lack of type info on base oop (`Object:NotNull+offset`). 
> 
> Testing: hs-tier1 - hs-tier6

Good point, Roland. 

Removed barrier-related logic and use `TypePtr::BOTTOM` instead.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5259


More information about the hotspot-compiler-dev mailing list