RFR: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java

[Tobias Hartmann]

On Fri, 30 Jul 2021 08:27:47 GMT, Roland Westrelin <roland at openjdk.org> wrote:

> The root cause of this bug is in PhaseStringOpts. In the middle of the
> chain of calls that are optimized out, there's a diamond Region/If. On
> most executions this diamond is optimized out by IGVN because once
> PhaseStringOpts is over, all the Region's Phis are removed. But
> because one input of the If/Bool/Cmp is set to top by PhaseStringOpts
> when calls are removed, it sometimes happen that top propagates to the
> If before the Region is optimized out. That causes control flow below
> the If to become dead while it should still be reachable.
> 
> The fix I propose is to have PhaseStringOpts removed the Region/If in
> that case.

Looks good.

Did you verify that the JavaFuzzer found test that Christian attached to the bug triggers the same issue?

src/hotspot/share/opto/stringopts.cpp line 283:

> 281:       Node* iff = n->in(1)->in(0);
> 282:       assert(iff->is_If(), "no if for the diamond");
> 283:       Node* bol = iff->in(1);;

Double `;`

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4944