RFR: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java [v2]

[Roland Westrelin]

On Tue, 31 Aug 2021 15:15:59 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge with master
>>  - review
>>  - fix
>
> src/hotspot/share/opto/stringopts.cpp line 282:
> 
>> 280:     } else if (n->is_Region()) {
>> 281:       Node* iff = n->in(1)->in(0);
>> 282:       assert(iff->is_If(), "no if for the diamond");
> 
> I assume that the only Region node listed in _control list is diamond Region.
> May be add assert to check that it is diamond region. Up to you.
> I would like to have separate RFE to have `is_diamond_region()` - we seems check it in few places.

I pushed an update. Is this what you had in mind?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4944