RFR: 8269119: C2: Avoid redundant memory barriers in Unsafe.copyMemory0 intrinsic [v3]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Sep 3 14:08:57 UTC 2021


> `Unsafe::copyMemory0` intrinsic unconditionally inserts barriers arounds the call to `unsafe_arraycopy` stub.
> It is a conservative approach and barriers can be avoided in most common cases (similar to what is done for scalar unsafe accesses).
> 
> `Unsafe::copyMemory()` performs argument validation which limits inputs either
> to off-heap location (null + absolute address) or primitive on-heap array.
> 
> The only cases when barriers are still needed are:
>  * mixed accesses (`Object+offset`);
>  * mismatched access due to lack of type info on base oop (`Object:NotNull+offset`). 
> 
> Testing: hs-tier1 - hs-tier6

Vladimir Ivanov has updated the pull request incrementally with two additional commits since the last revision:

 - Formatting
 - Handle bottom[] case

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5259/files
  - new: https://git.openjdk.java.net/jdk/pull/5259/files/aa9c083d..efb4e89b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5259&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5259&range=01-02

  Stats: 94 lines in 2 files changed: 74 ins; 1 del; 19 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5259.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5259/head:pull/5259

PR: https://git.openjdk.java.net/jdk/pull/5259


More information about the hotspot-compiler-dev mailing list