RFR: 8271341: Opcode() != Op_If && Opcode() != Op_RangeCheck) || outcnt() == 2 assert failure with Test7179138_1.java [v2]

[Vladimir Kozlov]

On Fri, 3 Sep 2021 07:41:15 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> src/hotspot/share/opto/stringopts.cpp line 282:
>> 
>>> 280:     } else if (n->is_Region()) {
>>> 281:       Node* iff = n->in(1)->in(0);
>>> 282:       assert(iff->is_If(), "no if for the diamond");
>> 
>> I assume that the only Region node listed in _control list is diamond Region.
>> May be add assert to check that it is diamond region. Up to you.
>> I would like to have separate RFE to have `is_diamond_region()` - we seems check it in few places.
>
> I pushed an update. Is this what you had in mind?

yes

-------------

PR: https://git.openjdk.java.net/jdk/pull/4944