RFR: 8273659: Replay compilation crashes with SIGSEGV since 8271911
Dean Long
dlong at openjdk.java.net
Wed Sep 15 21:27:56 UTC 2021
On Wed, 15 Sep 2021 09:05:26 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> src/hotspot/share/ci/ciReplay.cpp line 445:
>>
>>> 443: if (k == NULL) {
>>> 444: return NULL;
>>> 445: }
>>
>> Do we need a call to report_error() for a descriptive message for these failure paths?
>
> parse_method() has calls to report_error() when it returns NULL. I think it's true of parse_klass() except if SymbolTable::new_symbol() returns NULL (but can it return NULL?). Do you think extra messages make sense then?
No, I don't think new_symbol can return NULL. I think you're good to integrate.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5490
More information about the hotspot-compiler-dev
mailing list