RFR: 8273933: [TESTBUG] Test must run without preallocated exceptions [v3]
Tobias Hartmann
thartmann at openjdk.java.net
Mon Sep 20 14:49:25 UTC 2021
On Mon, 20 Sep 2021 14:26:40 GMT, Nils Eliasson <neliasso at openjdk.org> wrote:
>> Executing vmTestbase/jit/t/t105/t105.java with the fix for (JDK-8273277) makes the test fail when run with the following arguments:
>>
>> -XX:+TieredCompilation
>> -XX:Tier0BackedgeNotifyFreqLog=0
>> -XX:Tier2BackedgeNotifyFreqLog=0
>> -XX:Tier3BackedgeNotifyFreqLog=0
>> -XX:Tier2BackEdgeThreshold=1
>> -XX:Tier3BackEdgeThreshold=1
>> -XX:Tier4BackEdgeThreshold=1
>> -Xbatch
>>
>> The problem is that the tests expects a detailed message from ArrayIndexOutOfBoundsException, but this test will trigger the optimization that reuses preallocated exceptions that have an empty detailed exceptions.
>>
>> It is wrong for the test to assume exceptions messages.
>>
>> Solution disable preallocated exceptions with the flag -XX:-ProfileTraps.
>
> Nils Eliasson has updated the pull request incrementally with one additional commit since the last revision:
>
> Update t105.java
Looks good to me!
-------------
Marked as reviewed by thartmann (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5560
More information about the hotspot-compiler-dev
mailing list