RFR: 8274039: codestrings gtest fails when hsdis is present

[Patric Hedlin]

On Tue, 21 Sep 2021 13:41:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Please review this change to the (g)test-case "codestrings".
>> 
>> Adding missing regexp pattern to remove trailing **hsdis** printout due to padding on x64.
>
> test/hotspot/gtest/code/test_codestrings.cpp line 46:
> 
>> 44:     std::basic_string<char> tmp2 = std::regex_replace(tmp1, std::regex("\\s+<addr>:\\s+\\.inst\\t<addr> ; undefined"), "");
>> 45:     // Padding: x64
>> 46:     std::basic_string<char> red  = std::regex_replace(tmp2, std::regex("  <addr>:   hlt    \\n"), "");
> 
> Can we do `\\s+` here as well, like in `aarch64` case? Pretty sure this whitespace can be subtly different.

We could (and I did start in that end) but I decided to be as specific as possible since the pattern is such a "plain" one (unlike the pattern for aarch64 which is more distinct). But you do have a point of course. I will update the regexp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5606