RFR: 8274130: C2: MulNode::Ideal chained transformations may act on wrong nodes

Aleksey Shipilev shade at openjdk.java.net
Wed Sep 22 11:26:57 UTC 2021


On Wed, 22 Sep 2021 11:19:45 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

> This is actually cleaner but I'm not sure the change is strictly needed. In these specific transforms I think the types of the operands and the operation ought never to differ.

For types and current transforms, that might be true. It might not hold true in future. The patch, however, also makes sure these lines refer to the most actual nodes:


        igvn->_worklist.push(in1);
        igvn->_worklist.push(in2);

-------------

PR: https://git.openjdk.java.net/jdk/pull/5631


More information about the hotspot-compiler-dev mailing list