RFR: 8274039: codestrings gtest fails when hsdis is present [v2]

Aleksey Shipilev shade at openjdk.java.net
Wed Sep 22 13:30:57 UTC 2021


On Tue, 21 Sep 2021 16:28:10 GMT, Patric Hedlin <phedlin at openjdk.org> wrote:

> Just in order not to eat the last "\n" before the padded output (newlines are consumed at the end of the pattern).
> If you think consuming the newlines in the prefix is better (more obvious or just in line with the aarch64 pattern) we can use:
> 
> `std::regex("\\s+<addr>:\\s+hlt[ \\t]+(?!\\n\\s+;;)")`

This works on my machine too. But honestly, I don't care. Just pick one of these variants and unbreak the `tier1` :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/5606


More information about the hotspot-compiler-dev mailing list