RFR: 8273380: ARM32: Default to {ldrexd, strexd} in StubRoutines::atomic_{load|store}_long
Dean Long
dlong at openjdk.java.net
Wed Sep 22 23:00:55 UTC 2021
On Mon, 6 Sep 2021 11:28:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> Current ARM32 is one of few remaining uses of `os::is_MP`, the rest is removed by JDK-8188764. There are some interesting bugs in OS/libc that might give incorrect `os::is_MP` sometimes, e.g. in containers. Instead of risking it, we can default to {ldrexd,strexd} for ARMv7 (which always have them), and leave the `os::is_MP` path for ARMv6 (for which this is the only remaining way to load the 64-bit long).
>
> @mychris, you might want to take a look and do light performance testing for it?
>
> Additional testing:
> - [x] Linux ARM32 cross-compiled build completes
Seems good to me. Maybe another recent arm32 contributor could also look at this?
@mychris @bulasevich @dsamersoff @TheRealMDoerr
-------------
Marked as reviewed by dlong (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5379
More information about the hotspot-compiler-dev
mailing list