RFR: 8273380: ARM32: Default to {ldrexd, strexd} in StubRoutines::atomic_{load|store}_long [v2]

Aleksey Shipilev shade at openjdk.java.net
Thu Sep 23 15:58:00 UTC 2021


On Thu, 23 Sep 2021 10:43:41 GMT, Dmitry Samersoff <dsamersoff at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Move out bx
>>  - Merge branch 'master' into JDK-8273380-arm32-default-to-ldrex
>>  - First attempt
>
> src/hotspot/cpu/arm/stubGenerator_arm.cpp line 641:
> 
>> 639:       __ ldrexd(result_lo, Address(src));
>> 640:       __ clrex(); // FIXME: safe to remove?
>> 641:       __ bx(LR);
> 
> bx(LR) is common for all 3 branches, so it might be better to move it out

@dsamersoff, are you happy with new version?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5379


More information about the hotspot-compiler-dev mailing list