Integrated: 8273380: ARM32: Default to {ldrexd, strexd} in StubRoutines::atomic_{load|store}_long

Aleksey Shipilev shade at openjdk.java.net
Fri Sep 24 15:35:05 UTC 2021


On Mon, 6 Sep 2021 11:28:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Current ARM32 is one of few remaining uses of `os::is_MP`, the rest is removed by JDK-8188764. There are some interesting bugs in OS/libc that might give incorrect `os::is_MP` sometimes, e.g. in containers. Instead of risking it, we can default to {ldrexd,strexd} for ARMv7 (which always have them), and leave the `os::is_MP` path for ARMv6 (for which this is the only remaining way to load the 64-bit long). 
> 
> @mychris, you might want to take a look and do light performance testing for it?
> 
> Additional testing:
>  - [x] Linux ARM32 cross-compiled build completes

This pull request has now been integrated.

Changeset: 718eff2b
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/718eff2bb6e938440df9f7b982ef6d2f4060a759
Stats:     20 lines in 1 file changed: 8 ins; 8 del; 4 mod

8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long

Reviewed-by: dlong, dsamersoff

-------------

PR: https://git.openjdk.java.net/jdk/pull/5379


More information about the hotspot-compiler-dev mailing list