RFR: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

[Tobias Hartmann]

On Fri, 24 Sep 2021 10:36:34 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> The IR framework treated a `@Check` method as `@Test` method instead of the `@Test` method itself at IR matching time resulting in an internal framework exception.
> 
> While writing some tests for checked test I've noticed that a missing `@Arguments` annotation is not reported as `TestFormatException` but with a `RuntimeException` later when invoking the method in question. I also added the missing check for it.
> 
> Thanks,
> Christian

Looks good to me.

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java line 33:

> 31: /*
> 32:  * @test
> 33:  * @requires vm.debug == true & vm.compMode != "Xint" & vm.compiler2.enabled & vm.flagless

You might want to add an `@bug` tag.

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java line 201:

> 199:     }
> 200: 
> 201: 

Double newline.

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5678