RFR: 8284433: Cleanup Disassembler::find_prev_instr() on all platforms
Xiaolin Zheng
xlinzheng at openjdk.java.net
Fri Apr 8 02:37:44 UTC 2022
On Thu, 7 Apr 2022 13:01:39 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
> Hi Xiaolin,
>
> no worries, there was a bit of a fun undertone in my comments. It's hard to _hear_ such nuances when you are _writing_. I can live with the code being removed. Fresh and simple opinions are valuable, particularly as contrast to old sentimentality. As said above, I can add the code again should I find time to do it right (and complete) somewhen in the future. As of today, I can't say when somewhen will be.
>
> So please, go ahead with your PR.
>
> Best, Lutz
Thank you for the humor and consideration - I would feel very glad to see this code added back fully in the future, and sincerely hope this patch could push it a little forward.
Also thanks for reviewing! @vnkozlov @RealLucy
-------------
PR: https://git.openjdk.java.net/jdk/pull/8120
More information about the hotspot-compiler-dev
mailing list