RFR: 8281429: PhiNode::Value() is too conservative for tripcount of CountedLoop [v4]

[Roland Westrelin]

On Tue, 29 Mar 2022 15:17:04 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>> 
>>  - test fix
>>  - more test
>>  - test & fix
>>  - other fix
>>  - Merge branch 'master' into JDK-8281429
>>  - exp
>>  - review
>>  - Merge branch 'master' into JDK-8281429
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - ... and 3 more: https://git.openjdk.java.net/jdk/compare/c3280c4e...3a087b2c
>
> src/hotspot/share/opto/loopnode.cpp line 846:
> 
>> 844:   }
>> 845: 
>> 846:   // May not have gone thru igvn yet so don't use _igvn.type(phi) (PhaseIdealLoop::is_counted_loop() sets the iv phi's type)
> 
> Comment seems to be outdated as we are not querying the type of the phi anymore. Can you update it?

Right. I updated it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7823