RFR: 8284635: Crashes after 8282221: assert(ctrl == kit.control()) failed: Control flow was added although the intrinsic bailed out

[Srinivas Vamsi Parasa]

On Tue, 12 Apr 2022 05:21:23 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

> You need to un-problem-list the test (see [JDK-8284689](https://bugs.openjdk.java.net/browse/JDK-8284689)).

Please see the Unsigned.java test removed from the ProblemList in the newer commit.

> src/hotspot/share/opto/library_call.cpp line 2203:
> 
>> 2201: bool LibraryCallKit::inline_divmod_methods(vmIntrinsics::ID id) {
>> 2202:   Node* n = NULL;
>> 2203:   switch(id) {
> 
> Suggestion:
> 
>   switch (id) {

Please see the updated code style incorporating the suggested changes in the newer commit.

> src/hotspot/share/opto/library_call.cpp line 2208:
> 
>> 2206:       // Compile-time detect of null-exception
>> 2207:       if (stopped()) return true; // keep the graph constructed so far
>> 2208:       n = new UDivINode(control(), argument(0), argument(1)); break;
> 
> Suggestion:
> 
>       if (stopped()) {
>         return true; // keep the graph constructed so far
>       }
>       n = new UDivINode(control(), argument(0), argument(1));
>       break;
> 
> 
> While you are modifying this code, please also fix the code style.

Please see the updated code style incorporating the suggested changes in the newer commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8190