Integrated: 8284863: riscv: missing side effect for result in instruct vcount_positives

Feilong Jiang fjiang at openjdk.java.net
Fri Apr 15 06:19:44 UTC 2022


On Thu, 14 Apr 2022 08:40:06 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

> [JDK-8283364](https://bugs.openjdk.java.net/browse/JDK-8283364) replaces `StringCoding.hasNegatives` with `countPositives`.
> But the TEMP_DEF for result in vcount_positives was missing, without which `result != tmp` could not be guaranteed.
> If we add `assert_different_registers(result, tmp)` in `C2_MacroAssembler::count_positives_v`,
> JVM will complain assertion error for some test in hotspot and langtools when UseRVV is enabled.
> 
> After is patch, failed tests in hotspot and langtools are passed.

This pull request has now been integrated.

Changeset: ea0706de
Author:    Feilong Jiang <fjiang at openjdk.org>
Committer: Fei Yang <fyang at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/ea0706de82fffcb634cedf2cb6048c33a7d15004
Stats:     5 lines in 2 files changed: 3 ins; 0 del; 2 mod

8284863: riscv: missing side effect for result in instruct vcount_positives

Reviewed-by: fyang, shade

-------------

PR: https://git.openjdk.java.net/jdk/pull/8239


More information about the hotspot-compiler-dev mailing list