RFR: 8284742: x86: Handle integral division overflow during parsing [v5]

Quan Anh Mai duke at openjdk.java.net
Fri Apr 15 22:33:18 UTC 2022


On Fri, 15 Apr 2022 16:47:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits:
>> 
>>  - Merge branch 'master' into divMidend
>>  - fix test
>>  - use other nodes
>>  - minor formatting
>>  - removeRedundant
>>  - move code to parse instead
>>  - move div_fixup to share code
>>  - comment grammar
>>  - x86_32
>>  - add test cases
>>  - ... and 8 more: https://git.openjdk.java.net/jdk/compare/ea0706de...121a9240
>
> I agree that it should be specialized nodes. But the naming... It is easy to confuse with **no** (not).
> I am not big expert in naming but maybe move verbose: `NoOvfDiv`.
> 
> I also see that you removed `divL_eReg_imm32` and `modL_eReg_imm32` from `x86_32.ad`. Please explain.
> 
> Previous changes passed my testing.

@vnkozlov  I have renamed the nodes, thanks for your suggestions. The deletion was my mistake, I have redone that in the latest commit. Thank you very much.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8206


More information about the hotspot-compiler-dev mailing list