RFR: JDK-8277056: Combining several C2 Print* flags asserts in xmlStream::pop_tag [v2]

Tobias Holenstein duke at openjdk.java.net
Thu Apr 21 08:13:26 UTC 2022


On Wed, 20 Apr 2022 17:34:33 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed print to print_raw
>
> src/hotspot/share/opto/output.cpp line 1874:
> 
>> 1872:       }
>> 1873:       stringStream dump_asm_str;
>> 1874:       dump_asm_on(&dump_asm_str, node_offsets, node_offset_limit);
> 
> Does dump_asm_on also require InVM like print_metadata?  If it's not, is it easier to resume ttylock right after print_metadata?

There is a `GUARDED_VM_ENTRY` that may safepoint in `dump_asm_on` -> `dump_on` -> `dump2` -> `print_name_on` -> `print_symbol_on`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8203


More information about the hotspot-compiler-dev mailing list