RFR: 8278757: [s390] Implement AES Counter Mode Intrinsic [v7]

Lutz Schmidt lucy at openjdk.java.net
Fri Apr 22 11:31:25 UTC 2022


On Fri, 22 Apr 2022 11:21:31 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Please review (and approve, if possible) this pull request.
>> 
>> This is a s390-only enhancement. It introduces the implementation of an AES-CTR intrinsic, making use of the specific s390 instruction for AES counter-mode encryption.
>> 
>> Testing: SAP does no longer maintain a full build and test environment for s390. Testing is therefore limited to running some test suites (SPECjbb*, SPECjvm*) manually. But: identical code is contained in SAP's commercial product and thoroughly tested in that context. No issues were uncovered.
>> 
>> @backwaterred Could you please conduct some "official" testing for this PR? 
>> 
>> Thank you all!
>> 
>> Note: some performance figures can be found in the JBS ticket.
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8278757: honor review comments part 2 - resolve TODOs

PR is now updated to (hopefully) cover all review comments/requests. To efficiently implement the 128-bit increment operation, I had to provide new instructions (add with carry). 

Testing and generated code examination is not completed yet.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8142


More information about the hotspot-compiler-dev mailing list