RFR: 8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int) [v3]
Vladimir Kozlov
kvn at openjdk.java.net
Mon Apr 25 23:51:54 UTC 2022
On Mon, 25 Apr 2022 21:00:48 GMT, Dean Long <dlong at openjdk.org> wrote:
>> The new verifier checks for bytecodes falling off the end of the method, and the old verify does the same, but only for reachable code. So we need to be careful of falling off the end when compiling unreachable code verified by the old verifier.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>
> reformat
I agree with Dean's change.
As Tobias I thought about suggesting to add new function with check (similar to Dean's macro) which would call `make_block_at()` for next `bci`.
But it is only 2 places in C1 and 3 in C2.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8374
More information about the hotspot-compiler-dev
mailing list