RFR: 8290432: C2 compilation fails with assert(node->_last_del == _last) failed: must have deleted the edge just produced
Yi Yang
yyang at openjdk.org
Mon Aug 1 12:55:49 UTC 2022
Hi, can I have a review for this patch? [JDK-8273585](https://bugs.openjdk.org/browse/JDK-8273585) recognized the form of `Phi->CastII->AddI` as additional parallel induction variables. In the following program:
class Test {
static int dontInline() {
return 0;
}
static long test(int val, boolean b) {
long ret = 0;
long dArr[] = new long[100];
for (int i = 15; 293 > i; ++i) {
ret = val;
int j = 1;
while (++j < 6) {
int k = (val--);
for (long l = i; 1 > l; ) {
if (k != 0) {
ret += dontInline();
}
}
if (b) {
break;
}
}
}
return ret;
}
public static void main(String[] args) {
for (int i = 0; i < 1000; i++) {
test(0, false);
}
}
}
`val` is incorrectly matched with the new parallel IV form:

And C2 further replaces it with newly added nodes, which finally leads the crash:

I think we can add more constraints to the new form. The form of `Phi->CastXX->AddX` appears when using Preconditions.checkIndex, and it would be recognized as additional IV when 1) Phi != phi2, 2) CastXX is controlled by RangeCheck(to reflect changes in Preconditions checkindex intrinsic)
-------------
Commit messages:
- 8290432: C2 compilation fails with assert(node->_last_del == _last) failed: must have deleted the edge just produced
Changes: https://git.openjdk.org/jdk/pull/9695/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9695&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8290432
Stats: 77 lines in 2 files changed: 77 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/9695.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9695/head:pull/9695
PR: https://git.openjdk.org/jdk/pull/9695
More information about the hotspot-compiler-dev
mailing list