Integrated: 8287393: AArch64: Remove trampoline_call1

Evgeny Astigeevich duke at openjdk.org
Mon Aug 1 19:56:06 UTC 2022


On Thu, 21 Jul 2022 14:00:48 GMT, Evgeny Astigeevich <duke at openjdk.org> wrote:

> `trampoline_call` can do dummy code generation to calculate the size of C2 generated code. This is done in the output phase. In [src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp#L1042](https://github.com/openjdk/jdk/blob/e0d361cea91d3dd1450aece73f660b4abb7ce5fa/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp#L1042) Loom code needed to generate a trampoline call outside of C2 and without the output phase. This caused test crashes. The project Loom added `trampoline_call1` to workaround the crashes. 
> 
> This PR improves detection of C2 output phase which makes `trampoline_call1` redundant.
> 
> Tested the fastdebug/release builds:
> - `'gtest`: Passed
> - `tier1`...`tier2`: Passed

This pull request has now been integrated.

Changeset: 6cbc234a
Author:    Evgeny Astigeevich <eastig at amazon.com>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/6cbc234ad17c5a0c4b3d6ea76f807c27c1dc8330
Stats:     11 lines in 3 files changed: 4 ins; 2 del; 5 mod

8287393: AArch64: Remove trampoline_call1

Reviewed-by: aph, phh

-------------

PR: https://git.openjdk.org/jdk/pull/9592


More information about the hotspot-compiler-dev mailing list