RFR: 8291654: AArch64: assert from JDK-8287393 causes crashes
Xin Liu
xliu at openjdk.org
Mon Aug 1 23:28:32 UTC 2022
On Mon, 1 Aug 2022 22:13:53 GMT, Evgeny Astigeevich <duke at openjdk.org> wrote:
> https://github.com/openjdk/jdk/commit/6cbc234ad17c5a0c4b3d6ea76f807c27c1dc8330 adds an assert checking `in_scratch_emit_size` is set during the output phase of C2 compilation. The assert can fail if C1 uses `trampoline_call`.
> The assert is not needed as the calculation of `in_scratch_emit_size` is short-circuited to false if it is C1.
make sense. LGTM. I am not a reviewer.
It looks like that Compile::current() is c2-specific. It doesn't return Compile* when the task is compiled by c1.
-------------
Marked as reviewed by xliu (Committer).
PR: https://git.openjdk.org/jdk/pull/9709
More information about the hotspot-compiler-dev
mailing list