RFR: 8291799: IGV: make "Selection mode" a toggle button
Vladimir Kozlov
kvn at openjdk.org
Wed Aug 3 17:04:43 UTC 2022
On Wed, 3 Aug 2022 12:13:08 GMT, Tobias Holenstein <tholenstein at openjdk.org> wrote:
> In IGV, an open graph has two modes for interaction:
> `Panning mode` where the user can move the graph with the mouse.
> <img width="67" alt="Old Panning Mode" src="https://user-images.githubusercontent.com/71546117/182604386-84242157-d9d4-40c1-b00f-f36854997ece.png">
>
> `Selection mode` where the user can draw a selection rectangle with the mouse to select multiple nodes. This mode can also be accessed by holding down the `CMD/Ctrl` key on the keyboard.
> <img width="75" alt="Old Selection Mode" src="https://user-images.githubusercontent.com/71546117/182604430-e9f77ae3-7095-4190-af9a-5a7345443b8e.png">
>
>
> We remove the `Panning Mode` button (and the action `PanModeAction.java`) and make the `Select Mode` button (triggers `SelectionModeAction.java`) a toggle button:
> When it is selected, the user is in `Selection Mode`
> <img width="45" alt="New Selection Mode" src="https://user-images.githubusercontent.com/71546117/182604864-667443e9-fdfb-4e58-bce4-e9c729910715.png">
>
>
> Otherwise the user is in `Panning Mode` (default)
> <img width="45" alt="New Panning Mode" src="https://user-images.githubusercontent.com/71546117/182604761-5b11bc5e-253b-45cc-8cc4-fedf9f3698fc.png">
>
> This image shows a user that is selecting multiple nodes using the `Panning Mode` toggle button:
> <img width="684" alt="selecting" src="https://user-images.githubusercontent.com/71546117/182605776-b65e9aff-2c16-408e-8e8e-ff1f01c5522c.png">
Good.
-------------
Marked as reviewed by kvn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/9725
More information about the hotspot-compiler-dev
mailing list