RFR: 8291752: AArch64: Remove check_emit_size parameter from trampoline_call [v2]
Evgeny Astigeevich
duke at openjdk.org
Fri Aug 5 20:13:19 UTC 2022
On Fri, 5 Aug 2022 17:40:48 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Evgeny Astigeevich has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Restore original NativeCall::trampoline_jump functionality
>> - Substitute entry.target() with target
>> - Remove unneeded assert
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp line 1661:
>
>> 1659: bool C2_MacroAssembler::emit_trampoline_stub(int insts_call_instruction_offset, address target) {
>> 1660: if (ciEnv::current()->task() != NULL) {
>> 1661: assert(is_c2_compile(ciEnv::current()->task()->comp_level()), "not C2 compilation task");
>
> You don't need this assert. `C2_MacroAssembler` is used only in `.ad` files used by C2 only.
Done
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 864:
>
>> 862: // We might need a trampoline if branches are far.
>> 863: bool need_trampoline = far_branches();
>> 864: if (!need_trampoline && entry.rspec().type() == relocInfo::runtime_call_type && !CodeCache::contains(entry.target())) {
>
> In `CodeCache::contains(entry.target())` you can use `target` value.
Done
-------------
PR: https://git.openjdk.org/jdk/pull/9782
More information about the hotspot-compiler-dev
mailing list