RFR: 8265433: IGV: add graph tooltips with properties [v3]

Koichi Sakata ksakata at openjdk.org
Tue Aug 9 05:41:20 UTC 2022


On Mon, 8 Aug 2022 07:46:44 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Koichi Sakata has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Escape strings in tooltip
>>  - Undo an unintentional change
>>  - Discard changes for Outline window
>
> Thanks for addressing the feedback @jyukutyo! The changes look generally good, however there is still an issue with HTML escaping (perhaps the `escapeHTML` method is incomplete or not fully working?), see how the numeric 'index' and 'debug_id' values are interpreted in the tooltip: 
> ![single-quote-escaping](https://user-images.githubusercontent.com/8792647/183366183-184b33c2-5820-4a40-bfdb-181f761bb05b.png)

@robcasloz I've fixed it. I made a slip-up. Sorry.

-------------

PR: https://git.openjdk.org/jdk/pull/9740


More information about the hotspot-compiler-dev mailing list