[jdk19] RFR: 8292260: [BACKOUT] JDK-8279219: [REDO] C2 crash when allocating array of size too large

Fri Aug 12 17:54:34 UTC 2022

On Fri, 12 Aug 2022 13:25:11 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Regressions have been observed with the 11.0.16 and following releases. See [JDK-8291665](https://bugs.openjdk.org/browse/JDK-8291665) and [JDK-8288184](https://bugs.openjdk.org/browse/JDK-8288184). There might be more code-shapes out in the wild which trigger similar issues. Therefore we'd like to back out the patch of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219). Risk is obviously that the fix of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219) would no longer be there and potential other issues caused by the absence of [JDK-8279219](https://bugs.openjdk.org/browse/JDK-8279219) (that we don't know yet).  Yet it gets us back to where we were before JDK-8279219. It seems the safest option moving forward.
> 
> Backout is not clean because of additional changes in [graphKit.cpp](https://github.com/openjdk/jdk19/commit/aa7ccdf44549a52cce9e99f6569097d3343d9ee4#diff-be12257b7cfa0ec96698a5c3958f5aa98723582f68cf2648b376bbe40576b52dL3959) and test [TestFailedAllocationBadGraph.java](https://github.com/openjdk/jdk19/commit/955d61df30099c01c6968fa5851643583f71250e#diff-4593d9db5bd76ee640e4576d476203fed36a8a2737edff390fa0218dd2cce3a3).
> 
> I verified changes with test case from [JDK-8288184](https://bugs.openjdk.org/browse/JDK-8288184).
> 
> Passed tier1-5.

Looks good.

-------------

Marked as reviewed by vlivanov (Reviewer).

PR: https://git.openjdk.org/jdk19/pull/163