RFR: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion [v2]
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Tue Aug 16 09:04:38 UTC 2022
> `NeverBranch` nodes introduce fake branches out of infinite loops to simplify intermediate optimizations that assume full reachability:
> 
> `PhaseCFG::convert_NeverBranch_to_Goto()` transforms such nodes into simple `Goto` nodes, removing the fake branch and thus making its destination block unreachable:
> 
> This changeset removes the unreachable destination block created by `PhaseCFG::convert_NeverBranch_to_Goto()` from the list of basic blocks:
> 
> Removing unreachable blocks created by `PhaseCFG::convert_NeverBranch_to_Goto()` simplifies late control-flow analysis (for example, recomputing dominators during the output phase as required for late barrier analysis in Generational ZGC) and slightly reduces the size of the generated code.
>
> #### Testing
>
> - hs-tier1-3 (windows-x64, linux-x64, linux-aarch64, and macosx-x64; release and debug mode). The changeset does not introduce new test cases because it is already exercised by at least two existing ones (`compiler/inlining/StringConcatInfiniteLoop.java`, `compiler/loopopts/TestInfiniteLoopNotInnerMost.java`).
> - fuzzing (~30 min. on each platform).
Roberto Castañeda Lozano has updated the pull request incrementally with one additional commit since the last revision:
Apply style guidelines to surrounding code
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/9853/files
- new: https://git.openjdk.org/jdk/pull/9853/files/e633fbec..966a1279
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=9853&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=9853&range=00-01
Stats: 11 lines in 1 file changed: 5 ins; 0 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/9853.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/9853/head:pull/9853
PR: https://git.openjdk.org/jdk/pull/9853
More information about the hotspot-compiler-dev
mailing list