RFR: 8289051: C2: Cleanup PhaseCCP::analyze()

[Tobias Hartmann]

On Thu, 11 Aug 2022 07:03:15 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> As part of [JDK-8288683](https://bugs.openjdk.org/browse/JDK-8288683), which went into JDK 19, I separated out most of the included refactorings into this cleanup RFE to make the fix as small as possible.
> 
> This cleanup includes:
> - More comments and better descriptions.
> - Renamed some variables.
> - Split code into multiple methods to improve the readability.
> 
> Thanks,
> Christian

Nice cleanup. Looks good to me.

src/hotspot/share/opto/phaseX.cpp line 1757:

> 1755: 
> 1756: // In this analysis, all types are initially set to TOP. We iteratively call Value() on all nodes of the graph until
> 1757: // we reach a fix-point (i.e. no types change anymore). We start with a list that only contains the root node. Each time

Suggestion:

// we reach a fixed-point (i.e. no types change anymore). We start with a list that only contains the root node. Each time

-------------

Marked as reviewed by thartmann (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9833