RFR: 8292691: Move unnecessary inline methods out of compilerDefinitions.hpp

Igor Veresov iveresov at openjdk.org
Fri Aug 19 23:19:31 UTC 2022


On Fri, 19 Aug 2022 21:44:39 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Many of the inline functions in compilerDefinitions.hpp don't seem to be performance critical. They should be moved into compilerDefinitions.cpp to improve C++ compilation time
> 
> This reduces the inclusion of the following headers from 762 to 319:
> 
> - compiler_globals.hpp
> - c1_globals.hpp
> - c2_globals.hpp
> - jvmci_globals.hpp

Many of these are called in pretty hot paths in `CompilationPolicy`. That is when an interpreter or a c1-compiled method is invoking the policy on method invocations and back branches. So, I would like to keep these inline.

Could we move these to `compilerDefinitions.inline.hpp` and include it only where it's necessary?

-------------

PR: https://git.openjdk.org/jdk/pull/9953


More information about the hotspot-compiler-dev mailing list