RFR: JDK-8292561: Make "ReplayCompiles" a diagnostic product switch [v2]
Thomas Stuefe
stuefe at openjdk.org
Sat Aug 20 06:16:07 UTC 2022
On Fri, 19 Aug 2022 23:36:12 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback Vladimir
>
> src/hotspot/share/ci/ciEnv.hpp line 200:
>
>> 198: return ciEnv::_unloaded_ciinstance_klass;
>> 199: }
>> 200: }
>
> May be make this part of code as `ciReplay` method and place it into ciReplay.cpp to reduce code in .hpp file.
@vnkozlov , I moved the code into `ciObjectFactory::get_metadata()` since it seemed to fit there very well. Is that okay or do you really want it to live in ciReplay.cpp?
-------------
PR: https://git.openjdk.org/jdk/pull/9935
More information about the hotspot-compiler-dev
mailing list