RFR: 8292691: Move CompilerConfig::is_xxx() inline functions out of compilerDefinitions.hpp

Ioi Lam iklam at openjdk.org
Sat Aug 20 23:14:28 UTC 2022


On Fri, 19 Aug 2022 23:29:10 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

>> Many of the `CompilerConfig::is_xxx()` inline functions in compilerDefinitions.hpp depend on the following headers
>> 
>> - compiler_globals.hpp
>> - c1_globals.hpp
>> - c2_globals.hpp
>> - jvmci_globals.hpp
>> 
>> However, only a few files actually use these functions. To improve C++ compilation time, we should move these inline functions to compilerDefinitions.inline.hpp
>> 
>> This reduces the inclusion of the above headers from 762 to 321.
>
> It is reasonably hot. The interpreter calls it for every 128th invocation of a method and every 1024th back branch in a particular method. C1 calls it every 1024th invocation and 8192th back branch.

Thanks for the review @veresov and @vnkozlov 
I updated the issue title and description to reflect the final version.

-------------

PR: https://git.openjdk.org/jdk/pull/9953


More information about the hotspot-compiler-dev mailing list