Integrated: JDK-8292561: Make "ReplayCompiles" a diagnostic product switch

[Thomas Stuefe]

On Fri, 19 Aug 2022 06:53:08 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> See discussion: https://mail.openjdk.org/pipermail/hotspot-compiler-dev/2022-August/057988.html
> 
> Making ReplayCompiles a (diagnostic) runtime switch can help when facing problems with shipped release VMs:
> - Investigate the effects of compiler errors in shipped VMs to estimate the bug impact
> - Investigate if a given build is affected by a compiler bug
> 
> Making the option product increases libjvm.so text size by 54kb (Linux x64). No measurable runtime overhead.
> 
> Tests: Almost all tests in compiler/ciReplay generate replay files by inducing a crash with `-XX:CICrashAt`. That won't work in release builds. I added a simple test that checks that invalid replay files are correctly refused, and that test can also be done on a release VM. So we at least have a test for release that checks argument parsing.
> 
> (Note: I have https://github.com/openjdk/jdk/pull/9891 open, which could in the future serve as an alternative to CICrashAt by limiting the compiler arena).

This pull request has now been integrated.

Changeset: f9004fe4
Author:    Thomas Stuefe <stuefe at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f9004fe4438c30eb639e3c36e6531c306b836e36
Stats:     109 lines in 11 files changed: 81 ins; 25 del; 3 mod

8292561: Make "ReplayCompiles" a diagnostic product switch

Reviewed-by: kvn, xliu

-------------

PR: https://git.openjdk.org/jdk/pull/9935