RFR: 8290711: assert(false) failed: infinite loop in PhaseIterGVN::optimize [v2]

Roland Westrelin roland at openjdk.org
Tue Aug 23 15:41:28 UTC 2022


On Tue, 23 Aug 2022 07:21:51 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

> That looks reasonable!

Thanks for the review and the formatting tweaks that I took as is.

> src/hotspot/share/opto/phaseX.hpp line 585:
> 
>> 583:   static void push_load_barrier(Unique_Node_List& worklist, const BarrierSetC2* barrier_set, const Node* use);
>> 584:   void push_and(Unique_Node_List& worklist, const Node* parent, const Node* use) const;
>> 585:   Unique_Node_List _safepoints;
> 
> I suggest to move this field to the top of the class before the methods.

Moved in updated change.

-------------

PR: https://git.openjdk.org/jdk/pull/9961


More information about the hotspot-compiler-dev mailing list