RFR: 8291649: multiple tests failing with -Xcomp after JDK-8290034 [v2]

Jatin Bhateja jbhateja at openjdk.org
Fri Aug 26 08:37:03 UTC 2022


On Fri, 26 Aug 2022 06:36:59 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Yes, that could work.
>> 
>> This also works, and feels appropriately short + sweet to me:
>> 
>> https://github.com/rose00/jdk/pull/new/moveBits
>> 
>> (I also added a 90+% level gtest.)
>> 
>> (Sorry; amended with `constexpr` and force-pushed…)
>
> I took John's code and made various (I think) improvements:
> https://github.com/openjdk/jdk/compare/master...kimbarrett:openjdk-jdk:reverse-bits?expand=1

constexpr enables compiler to bypass usual in-lining constraints and inline the method body if all the arguments are constants at compile time under an assumption that IR pallet will be constant folded to a single value,  in given context JIT compiler uses reverse_bit utility to constant fold Reverse IR node with constant inputs. Thus technically constexpr will not have much impact here.

-------------

PR: https://git.openjdk.org/jdk/pull/9987


More information about the hotspot-compiler-dev mailing list