RFR: 8292694: x86_64 c2i/i2c adapters may use more stack space than necessary [v2]

Vladimir Kozlov kvn at openjdk.org
Sat Aug 27 00:21:07 UTC 2022


On Sat, 27 Aug 2022 00:17:42 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The c2i adapter includes the return address in the alignment calculation, making %rsp always mis-aligned according to the ABI.
>> 
>> The i2c adapter aligns "extrawords" even though %rsp is aligned later, and the incoming stack is not guaranteed to be aligned.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert change to generate_Continuation_doYield_entry

Yes, I was wandering about generate_Continuation_doYield_entry().

Looks good.

-------------

Marked as reviewed by kvn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10034


More information about the hotspot-compiler-dev mailing list