RFR: 8291649: multiple tests failing with -Xcomp after JDK-8290034 [v4]

Kim Barrett kbarrett at openjdk.org
Sun Aug 28 02:29:14 UTC 2022


On Sat, 27 Aug 2022 16:58:48 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi,
>> 
>> This bug fix patch fixes the incorrect computation during constant folding of Reverse[IL] IR node.
>> A new utility class has been added to optimize computation of reverse_bit operation using GCC built-ins.
>> 
>> Kindly review and share your feedback.
>> 
>> Best Regards,
>> Jatin
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8291649: Incorporating further refinements from Kim.

Looks good, other than the changes to subnode.cpp.  Those also look good to
me, but my knowledge in that part of the code is very limited, so you
shouldn't count me as a reviewer for that part.

I think you should probably add @rose00  and me as contributors.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9987


More information about the hotspot-compiler-dev mailing list