RFR: 8292972: Initialize fields if CodeBlobIterator shortcuts without heaps
Christian Hagedorn
chagedorn at openjdk.org
Mon Aug 29 06:07:14 UTC 2022
On Fri, 26 Aug 2022 09:35:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> SonarCloud reports that `CodeBlobIterator::_code_blob` is not initialized on shortcut path:
>
>
> CodeBlobIterator(LivenessFilter filter, T* nm = NULL)
> : _only_not_unloading(filter == only_not_unloading)
> {
> if (Filter::heaps() == NULL) {
> return; <---- here
> }
>
>
> It seems that we don't have an actual bug here, as iterator shortcuts on `_heap == _end`, but it would be cleaner to avoid garbage anyway.
Looks good!
-------------
Marked as reviewed by chagedorn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10041
More information about the hotspot-compiler-dev
mailing list