RFR: 8291600: [vectorapi] vector cast op check is not always needed for vector mask cast [v5]

Xiaohong Gong xgong at openjdk.org
Wed Aug 31 06:10:08 UTC 2022


On Wed, 31 Aug 2022 03:55:04 GMT, Jie Fu <jiefu at openjdk.org> wrote:

>> From the check https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L2485, we know the basic mask type of dst and src must be the same. So just checking `src_type` is ok here. Besides, this part of changes will be removed finally after I unify the vector mask cast operation.
>
> But the mismatch seems strange to me.
> 
> Maybe, you can 
> 1) Add `dst_type->isa_vectmask()` check here, or
> 2) Also delete `dst_type->isa_vectmask()`  (https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/vectorIntrinsics.cpp#L2551)

I'v added the dst_type check in the latest commit. Thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/9737


More information about the hotspot-compiler-dev mailing list